Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubernetes-run] Option to delete pod automatically on failure #343

Closed
KnVerey opened this issue Oct 9, 2018 · 1 comment
Closed

[kubernetes-run] Option to delete pod automatically on failure #343

KnVerey opened this issue Oct 9, 2018 · 1 comment
Labels
✨ enhancement Improvement or small feature

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Oct 9, 2018

Follow-up to #337

One of our internal apps (ActiveFailover) does this itself before retrying. Seems like a sensible option to have built-in upstream.

We'll need to consider whether it makes sense to also delete the pod on timeout (and if that needs to be a separate option).
@KnVerey
Copy link
Contributor Author

KnVerey commented Jan 9, 2019

I don't think we should do this upstream until we have another request for it. Different users may want the deletion to happen under different circumstances (success/failure status/other failure/all failures/timeouts/failures and timeouts/...) and I don't think it is all that terrible to have AF deleting its pods under its desired circumstances as it does right now.

@KnVerey KnVerey closed this as completed Jan 9, 2019
@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement Improvement or small feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnVerey