Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support krane.shopify.io annotations #525

Closed
dturn opened this issue Aug 14, 2019 · 0 comments · Fixed by #539
Closed

Add support krane.shopify.io annotations #525

dturn opened this issue Aug 14, 2019 · 0 comments · Fixed by #539
Assignees
@RyanBrushett @adrianna-chang-shopify
Labels
krane [ProdX-GSD]

Comments

@dturn
Copy link
Contributor

dturn commented Aug 14, 2019 •
edited
Loading

Problem

We're transitioning from kubernetes-deploy to krane. This means that we need to support krane.shopify.io annotations.

Possible solution

Create new constants and use both.

Acceptance criteria

  • A user can use current annotations
  • A user can use krane.shopify.io for annotations
  • Documentation indicates that krane.shopify.io annotations are preferred and kubernetes-deploy are deprecated.

Additional context

#256 (comment)
@dturn dturn self-assigned this Aug 14, 2019
@dturn dturn removed their assignment Aug 28, 2019
Merged
6 tasks
@RyanBrushett RyanBrushett self-assigned this Aug 30, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanBrushett RyanBrushett

@adrianna-chang-shopify adrianna-chang-shopify

Labels
krane [ProdX-GSD]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Krane annotations Shopify/krane
3 participants
@RyanBrushett @dturn @adrianna-chang-shopify