Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Krane Global Deploy #588

Closed
dturn opened this issue Oct 11, 2019 · 1 comment
Closed

Krane Global Deploy #588

dturn opened this issue Oct 11, 2019 · 1 comment
Assignees
@dturn
Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229

Comments

@dturn
Copy link
Contributor

dturn commented Oct 11, 2019

#567 Causes krane deploy to fail validation when a global resource is present. This is a breaking change from kubernetes-deploy. As a result I believe we need to provide a krane global-deploy command to that only allows global resources to be deployed.
@dturn dturn added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Oct 11, 2019
@dturn dturn self-assigned this Oct 11, 2019
This was referenced Oct 11, 2019
Closed
Closed
@dturn
Copy link
Contributor Author

dturn commented Nov 12, 2019

Done #602 & #612

@dturn dturn closed this as completed Nov 12, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dturn dturn

Labels
krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dturn