Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need for a gvk override list #699

Closed
dturn opened this issue Feb 18, 2020 · 2 comments
Closed

Remove the need for a gvk override list #699

dturn opened this issue Feb 18, 2020 · 2 comments

Comments

@dturn
Copy link
Contributor

dturn commented Feb 18, 2020

We dynamically determine the group/version/kind for pruning based on output of kubectl commands. However, there isn't a simple strategy that can do this correctly, so we maintain a an override list that is growing #696.

Ideally we'd be able to leverage kubeclient to determine valid GVKs. It looks like that will require adding some code in https://github.com/abonas/kubeclient to expose this information. If dont right this should also eliminate the need to manually build kubeclient instances based on paths / version https://github.com/Shopify/krane/blob/master/lib/krane/kubeclient_builder.rb#L19 . Instead kubeclient would have a new method that will give us an instance based on just a kind and its internal discovery mechanism would know the preferred group/version.

@dturn
Copy link
Contributor Author

dturn commented Oct 20, 2020

@dturn
Copy link
Contributor Author

dturn commented Feb 10, 2021

Fixed in #778

@dturn dturn closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant