Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch dry-running may fail slower than we expect #797

Open
timothysmith0609 opened this issue Feb 1, 2021 · 0 comments
Open

Batch dry-running may fail slower than we expect #797

timothysmith0609 opened this issue Feb 1, 2021 · 0 comments
Assignees

Comments

@timothysmith0609
Copy link
Contributor

timothysmith0609 commented Feb 1, 2021

Server-side dry run can fail when an admission controller does not declare itself as having no side effects. In the case of some of our deploys, we go through the effort of dry-running every resource, only to fail on ones that go through such an admission hook. The result is a long, failed, attempt at batch running, followed by a resource-by-resource validation (which succeeds by virtue of being mostly client-side).

Three approaches that come to mind are:

  • Grant the ability to pass in a denylist of resource kinds we don't want to validate server-side
  • Allow explicitly declaring whether to use batch server-side dry running or client side
  • Get all admission controllers and check which ones support dry-run; client-side check those resources and remove them from the batch of server-side dry-run resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant