Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hard-fail when current_sha is empty #916

Open
1 task done
beatak opened this issue Jan 31, 2023 · 0 comments
Open
1 task done

Option to hard-fail when current_sha is empty #916

beatak opened this issue Jan 31, 2023 · 0 comments

Comments

@beatak
Copy link

beatak commented Jan 31, 2023

Feature request

  • If the maintainers agree with the feature as described here, I intend to submit a Pull Request myself.
    • I can try, if someone points me how to run a test suite in rancher-desktop instead of minikube

Proposal: Currently, if you do krane --current-sha="" … you'll get current-sha is optional but can not be blank, it seems like a failure, but it still outputs the manifest, and the build could go thru. So, I'd like to propose a way to make it a hard-stop. I'm open to suggestions on whether the flag should be a command line argument like --fail-blank-current-sha, or some environmental variable KRANE_FAIL_BLANK_CURRENT_SHA (I see KRANE_LOG_LINE_LIMIT exists).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant