Fix statefulset pod selector #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilikeorangutans
approved these changes
Apr 19, 2024
devonboyer
reviewed
Apr 19, 2024
| @@ -65,7 +65,7 @@ def desired_replicas | |||
| def parent_of_pod?(pod_data) | |||
| return false unless pod_data.dig("metadata", "ownerReferences") | |||
| pod_data["metadata"]["ownerReferences"].any? { |ref| ref["uid"] == @instance_data["metadata"]["uid"] } && | |||
| @instance_data["status"]["currentRevision"] == pod_data["metadata"]["labels"]["controller-revision-hash"] | |||
| @instance_data["status"]["updateRevision"] == pod_data["metadata"]["labels"]["controller-revision-hash"] | |||
There was a problem hiding this comment.
I'm trying to figure out whether updateRevision will be empty the first time a StatefulSet is deployed.
There was a problem hiding this comment.
I think it does the right thing and sets updatedRevision and currentRevision to the same thing if there is no revision history:
There was a problem hiding this comment.
Good question, but as you pointed out, it looks like it should do the right thing.
|
🎩 'ed and seems to have fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
When deploying a StatefulSet, deploys could sporadically be marked failed due to Krane monitoring the health of the current revision's pods, not the updated revision. This PR updates the logic to monitor the updated revision.
How is this accomplished?
StatefulSet#parent_of_pod?is the method that filters pods. I've updated it to select pods matching.status.updateRevision.What could go wrong?
...