Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI Setup for k8s 1.7.x, 1.8.x #200

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Update CI Setup for k8s 1.7.x, 1.8.x #200

merged 2 commits into from
Nov 10, 2017

Conversation

stefanmb
Copy link
Contributor

@stefanmb stefanmb commented Nov 1, 2017 •
edited
Loading

Run CI on:

  • k8s 1.6.4 (this is the latest version supported by this CI setup)
  • k8s 1.7.x latest
  • k8s 1.8.x latest
  • k8s 1.9.x latest (nightly builds only)

Latest includes beta/alpha releases.

Requires #198 for passing 1.8.x+ builds.

@stefanmb stefanmb changed the title Update pipeline.yml (WIP) CI - ignore me Nov 1, 2017
@stefanmb stefanmb changed the title (WIP) CI - ignore me Update CI Setup for k8s 1.7.x, 1.8.x Nov 3, 2017
@stefanmb stefanmb requested a review from KnVerey November 3, 2017 20:02
KnVerey
KnVerey reviewed Nov 6, 2017
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 when #198 is in

.buildkite/pipeline.yml Outdated
- name: 'Run Test Suite (:kubernetes: 1.6.4)'
queue: minikube-v1.8.2
env:
LOGGING_LEVEL: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for buildkite or ultimately for k8s? If the latter, should we set it in bin/ci like we do a few other env vars?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOGGING_LEVEL refers to the Kubernetes components. The default (if omitted) is 4. I included it here explicitly as documentation to make it obvious how to get a more verbose log.

Moving it to bin/ci is too late as the env var has to be present during the initial k8s bootstrap before actually executing the command.

@stefanmb
Copy link
Contributor Author

@KnVerey I've updated this PR, the latest builds have passed. The 1.9.x-latest builds will happen nightly, see: https://buildkite.com/shopify/kubernetes-deploy-gem-nightly/

This new pipeline has no Github hooks, it is launched via the nightly schedule or manually.

It's possible to set up individual email notifications for that branch when the fail/pass status changes.

KnVerey
KnVerey approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to set up individual email notifications for that branch when the fail/pass status changes.

Could we make those post to slack like we do for Splunk alerts?

@stefanmb
Copy link
Contributor Author

Could we make those post to slack like we do for Splunk alerts?

Investigating some reasonable way to do that.

@stefanmb stefanmb merged commit 56e7a4f into master Nov 10, 2017
@stefanmb stefanmb deleted the k8s_18_ci branch November 10, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanmb @KnVerey