More powerful bindings parser #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushrax
approved these changes
Dec 4, 2017
| end | ||
|
|
||
| def parse_csv(string) | ||
| lines = CSV.parse(string) |
There was a problem hiding this comment.
This might be baseless but I'm not 100% certain that this will parse things that worked before (which just used split(',')). The most obvious example would be a newline in a value.
However, the additional quote parsing flexibility would be nice, so maybe the answer is "ship and see"
|
can you add some json to the integration tests for the bindings? |
ibawt
approved these changes
Dec 4, 2017
|
Hm I don't see an integration test that exercises the |
|
ok should be fine then. I thought for some reason we did it from the command. You will have to super careful with the shell interpolations though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes-deploy --bindingsparser. Previously, it was not possible to pass bindings for which the value contains commas (because the comma was interpreted as a separator). This is now possible via something like--bindings='"foo=bar,42",bla=42'.--bindings='{ "foo": 42, "bar": 17 }'.