Fetch debug info in parallel #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
approved these changes
Jan 12, 2018
| @@ -322,6 +328,10 @@ def create_definition_tempfile | |||
| file&.close | |||
| end | |||
|
|
|||
| def type_supports_logs? | |||
There was a problem hiding this comment.
Its a nit but just supports_logs?
stefanmb
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We noticed that when a bunch (~10) of core's large deployments fail, there can be a 5+ minute delay between the polling loop completing and the statsd metric for completion being emitted. The only interesting thing that happens in that period is the fetching of the debug information (i.e. logs and events). Unlike all the other API call points (validation, syncing), we're still doing this one in serial. We may also want to introduce an option to skip this altogether (or automatically disable it in some circumstance?), but I think not parallelizing here was an oversight to begin with.
@dturn @stefanmb
cc @Shopify/cloudplatform