required-rollout takes a percent #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
commented
Jan 18, 2018
| @@ -168,16 +167,27 @@ def find_latest_rs(deployment_data) | |||
| end | |||
|
|
|||
| def min_available_replicas | |||
There was a problem hiding this comment.
I need to rework this function I dropped in the value from the annotation, but that鈥檚 not the right.
There was a problem hiding this comment.
Fixed the logic. Ready for 馃憖
KnVerey
approved these changes
Jan 18, 2018
| end | ||
|
|
||
| def percent?(value) | ||
| value =~ /%/ |
| assert deploy.deploy_succeeded? | ||
|
|
||
| deploy = build_synced_deployment( | ||
| template: build_deployment_template(status: deployment_status, rollout: '34%', max_unavailable: 2), |
There was a problem hiding this comment.
let's add 0% and 100% cases for good measure. We could also leave out max_unavailable in this test, since it shouldn't matter. Or we could set it to 0% to prove it isn't being referenced.
| def test_validation_with_percent_rollout_annotation | ||
| deploy = build_synced_deployment(template: build_deployment_template(rollout: '10%'), replica_sets: []) | ||
| deploy.kubectl.expects(:run).with('create', '-f', anything, '--dry-run', '--output=name', anything).returns( | ||
| ["", "super failed", SystemExit.new(1)] |
There was a problem hiding this comment.
If we're trying to prove that this value is valid, why not make this command return 0 and assert deploy_validate_definition/assert_empty deploy.validation_error_msg?
| @@ -80,6 +80,34 @@ def test_deploy_succeeded_with_max_unavailable | |||
| refute deploy.deploy_succeeded? | |||
| end | |||
|
|
|||
| def test_deploy_succeeded_with_annotation_as_number | |||
dturn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#208 added the
kubernetes-deploy.shopify.io/required-rolloutannotation. There is a corner case whenmaxUnavailableis0%and the annotation becomes a no-op. This PR allows a user to specify a number or a percent (e.g.10or15%) to the annotation instead of using the value frommaxUnavailable.Previously there was a concern that allowing users to provide their own value would allow the user to 馃敨 馃懀 . Would it be better if this feature required
maxUnavailableto be0%/ only took a%? That would limit the blast radius.cc: @dwradcliffe