Assume no strategy is rollingUpdate on Vallidation #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
approved these changes
May 17, 2018
| kubectl.expects(:run).with('create', '-f', anything, '--dry-run', '--output=name', anything).returns( | ||
| ["", "super failed", SystemExit.new(1)] | ||
| ) | ||
| refute deploy.validate_definition(kubectl) |
There was a problem hiding this comment.
I expected this test ("test validation works") to pass validation. I see that technically this is proving that only super validation failed, but I think having it pass overall would be more approachable.
There was a problem hiding this comment.
Yeah, not sure what I was thinking. Its fixed.
|
Felix seems to be on vacation right now. @timothysmith0609 can you take a quick look at this? |
|
ping |
timothysmith0609
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The required-rollout requires a rollout strategy to be explicitly set or else a validation error is raised. However, the k8s default rollout strategy is compatible with the required-rollout annotation. This pr allows for that case.
Fixes: #268