Check for presence of the `STATSD_IMPLEMENTATION' env: #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
suggested changes
Aug 7, 2018
lib/kubernetes-deploy/statsd.rb
Outdated
| @@ -15,7 +15,7 @@ def self.build | |||
| if ENV['STATSD_DEV'].present? | |||
| ::StatsD.backend = ::StatsD::Instrument::Backends::LoggerBackend.new(Logger.new($stderr)) | |||
| elsif ENV['STATSD_ADDR'].present? | |||
| statsd_impl = ENV['STATSD_IMPLEMENTATION'].empty? ? "datadog" : ENV['STATSD_IMPLEMENTATION'] | |||
| statsd_impl = ENV['STATSD_IMPLEMENTATION'].to_s.empty? ? "datadog" : ENV['STATSD_IMPLEMENTATION'] | |||
There was a problem hiding this comment.
ENV['STATSD_IMPLEMENTATION'].present? is probably what you want.
Edouard-chin
force-pushed
the
ec-statsd-env
branch
5 times, most recently
from
ef23a5d
to
f5848be
Compare
n1koo
approved these changes
Aug 7, 2018
- Calling `empty?` when ENV['STATSD_IMPLEMENTATION'] isn't set makes kubernetes-deploy to crash. Fixing the issue by calling ActiveSuport's `present?` instead
Edouard-chin
force-pushed
the
ec-statsd-env
branch
from
f5848be
to
dcf3dcc
Compare
Edouard-chin
changed the title
STATSD_IMPLEMENTATION env is a string:
dturn
approved these changes
Aug 7, 2018
stefanmb
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for presence of the `STATSD_IMPLEMENTATION' env:
Calling
empty?when ENV['STATSD_IMPLEMENTATION'] isn't set makes kubernetes-deploy to crash.Fixing the issue by calling ActiveSuport's
present?instead