Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.14 to CI #461

Merged
merged 2 commits into from
May 15, 2019
Merged

Add 1.14 to CI #461

merged 2 commits into from
May 15, 2019

Conversation

dturn
Copy link
Contributor

@dturn dturn commented Apr 2, 2019

What are you trying to accomplish with this PR?
Support the latest k8s release.

How is this accomplished?
Adding it to ci

What could go wrong?
Not much, its just CI instructions

@dturn
Copy link
Contributor Author

dturn commented Apr 2, 2019

This is unlikely to pass 1.14 CI w/o #460

@KnVerey
Copy link
Contributor

KnVerey commented Apr 2, 2019

True, but it is currently failing during setup, so looks like we have other work to do

@dturn
Copy link
Contributor Author

dturn commented Apr 2, 2019

True, but it is currently failing during setup, so looks like we have other work to do

Yep, was hoping it would just work, but not at all surprised.

@benlangfeld
Copy link
Contributor

Would you mind pasting the other failures here?

@dturn
Copy link
Contributor Author

dturn commented Apr 10, 2019

Would you mind pasting the other failures here?

#460 was merged. This PR is just to enable 1.14 runs on our internal CI. The failures aren't related to the code in this repo, we just haven't added support for 1.14 to our CI. I'm trying to find some time to look at this, but I don't think it's blocking anything, we just don't have as much coverage as we'd like for now.

@RyanBrushett RyanBrushett force-pushed the ci-1.14 branch 2 times, most recently from b713126 to ae9b91b Compare May 13, 2019 22:09
@RyanBrushett
Copy link
Contributor

RyanBrushett commented May 13, 2019

  • Do we want to deprecate 1.10? I acted as though we did but, checking. I can also do it in a different PR if that's better.
  • I'll add a changelog entry tomorrow.
    CI will still fail until probably tomorrow. Will update here then.

@dturn since I can't request you for a review on a PR you opened 😄

@dturn
Copy link
Contributor Author

dturn commented May 14, 2019

Do we want to deprecate 1.10? I acted as though we did but, checking. I can also do it in a different PR if that's better.

I think we actually need to keep running 1.10 for a bit longer.

@RyanBrushett
Copy link
Contributor

I'll do that in a separate PR. Cleaning this up shortly.

Co-authored-by: Danny Turner <daniel.turner@shopify.com>
Copy link
Contributor

@RyanBrushett RyanBrushett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to your original cut of this.

I'll re-run CI shortly.

Copy link
Contributor Author

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't officially approve a PR I opened but ✅ from me.

Copy link
Contributor

@jessie-JNing jessie-JNing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RyanBrushett RyanBrushett self-assigned this May 14, 2019
@RyanBrushett RyanBrushett merged commit 393a065 into master May 15, 2019
@RyanBrushett RyanBrushett deleted the ci-1.14 branch May 15, 2019 15:29
CHANGELOG.md Show resolved Hide resolved
@RyanBrushett RyanBrushett temporarily deployed to rubygems July 3, 2019 18:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants