Do not add doc separator when render result is blank #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBrushett
approved these changes
Apr 18, 2019
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fix a regression from #454. It is causing the template validator for my Web PR to fail because a file entire content is rendered conditionally. Before that PR, the render result was an empty file, which I think makes sense. Now it instead contains an empty YAML doc. We should not be adding that header.
How is this accomplished?
Add a regression test and a presence check on the render result.
What could go wrong?
There's a reason I'm not thinking of why having an extra header could be a good thing?
@Shopify/cloudx