Relax oj dependency #471
Merged
Relax oj dependency #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dturn
approved these changes
Apr 24, 2019
timothysmith0609
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Relax our dependency on the oj gem. The repo history doesn't show a particular reason for needing
3.7, so let's just pin to the major version. This came to my attention because Shopify Core depends onoj 3.6.How is this accomplished?
Change the gemspec.
What could go wrong?
Something between 3.0 and 3.7 turns out to be important, and we get a bug report that our dependency is incorrectly specified. I did read through https://github.com/ohler55/oj/blob/master/CHANGELOG.md and nothing jumped out at me given our super basic usage of this gem.
@Shopify/cloudx