Fix: Undefined method "merge" on LabelSelector #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes "undefined method `merge` for KubernetesDeploy::LabelSelector"
Fixes "undefined method `reverse_merge`" on hash
ramontayag
force-pushed
the
undefined_merge
branch
from
b014d2d
to
573dbc4
Compare
dturn
approved these changes
May 27, 2019
RyanBrushett
approved these changes
May 27, 2019
|
Thanks for the bug fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
When deploying with a
--selector, fix exceptions:undefined method "merge"onLabelSelectorandundefined methodreverse_merge!onHash`How is this accomplished?
reverse_mergelibWhat could go wrong?
Not sure - it's already busted now