Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google auth to 0.8 #512

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Update google auth to 0.8 #512

merged 2 commits into from
Jul 11, 2019

Conversation

karanthukral
Copy link
Contributor

What are you trying to accomplish with this PR?

  • Update googleauth gem to 0.8
  • Update is due to dependency conflicts with another one of our tools

What could go wrong?

  • Ran the tests locally and they are seem to work as expected

cc/ @peiranliushop @stefanmb

stefanmb
stefanmb approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@stefanmb stefanmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI.

@peiranliushop
Copy link
Contributor

peiranliushop commented Jul 11, 2019 •
edited
Loading

This is quite useful. The current state blocks all app that depends on both cluster-registry and kubernetes-deploy to upgrade cluster-registry to above 0.2.4

dturn
dturn approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karanthukral Can you 🎩 before merge

@karanthukral
Copy link
Contributor Author

Tophatted by deploying cumulus-cat locally.

@karanthukral karanthukral merged commit 4512fcf into master Jul 11, 2019
@karanthukral karanthukral deleted the update-googleauth branch July 11, 2019 16:54
@karanthukral karanthukral temporarily deployed to rubygems July 11, 2019 17:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanmb stefanmb stefanmb approved these changes

@dturn dturn dturn approved these changes

@KnVerey KnVerey Awaiting requested review from KnVerey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karanthukral @peiranliushop @stefanmb @dturn