render implicit yml multi doc file correctly #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirceu
reviewed
Sep 11, 2019
| implicit = true | ||
| YAML.parse_stream(rendered_content, "<rendered> #{filename}") { |d| implicit = d.implicit } | ||
| implicit = [] | ||
| YAML.parse_stream(rendered_content, "<rendered> #{filename}") { |d| implicit << d.implicit } |
There was a problem hiding this comment.
Do we need to change anything related to this here as well or that doesn't matter?
There was a problem hiding this comment.
This bug happens because we take all the resources we're provided and turn it into a single output stream. So its important to have separators between each doc in the final output even if the input doc is implicit. The code you linked is for erb rendering a single file (which can contain partials) but it's important that we render it as requested by the user.
dirceu
approved these changes
Sep 11, 2019
lei-lo
approved these changes
Sep 13, 2019
dturn
force-pushed
the
render-implicit
branch
from
78bb04a
to
fbc7bee
Compare
dturn
force-pushed
the
render-implicit
branch
from
fbc7bee
to
5745ef9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fix a bug where we fail to add
---to an implicit document if there are multiple documents in the file.Fixes: #513
How is this accomplished?
Only test the implicitness of the first yaml doc in a file.
What could go wrong?
We start adding doc separators when we shouldn't and create empty docs.