Support multiple filenames in krane deploy #606
Conversation
There was a problem hiding this comment.
Tested things locally and it makes sense. Since -f is already working for render_command, and there's some overlap between how those 2 tasks work, that's not surprising.
The formatting between the various X_command.rbs are all different: e.g symbol vs string keys, line-per-arg vs fit-per-line. Might be a good tidy-up to make sure these are all consistent, but that's not related to this PR.
lib/krane/cli/deploy_command.rb
Outdated
| @@ -13,7 +13,7 @@ class DeployCommand | |||
| "bindings" => { type: :array, banner: "foo=bar abc=def", | |||
| desc: "Expose additional variables to ERB templates (format: k1=v1 k2=v2, JSON string or file "\ | |||
| "(JSON or YAML) path prefixed by '@')" }, | |||
| "filenames" => { type: :string, banner: '/tmp/my-resource.yml', aliases: :f, required: true, | |||
| "filenames" => { type: :array, banner: '/tmp/my-resource.yml', aliases: :f, required: true, | |||
There was a problem hiding this comment.
style nit (scope might be beyond this PR): The formatting for each X_command.rb is different for each command. E.g. render uses symbolized keys, run uses line-per-field, etc. Would be nice to have these be consistent
| "filenames" => { type: :array, banner: 'config/deploy/production config/deploy/my-extra-resource.yml', | ||
| aliases: :f, required: true, | ||
| desc: "Directories and files that contains the configuration to apply" }, |
There was a problem hiding this comment.
For consistency let's add this to render as well. Edit: by 'this', I mean the banner description
What are you trying to accomplish with this PR?
Currently the
-fflag in forkrane deployonly supports a single filename or directly. This appears to be an oversight from waiting for thor to handle repeated flags.Krane rendersupports the multiple files/directories.How is this accomplished?
Change thor type to an array.
What could go wrong?
We don't support csv only white space separated.