Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new DL] DropZone example, when adding a file illustration needs to be updated #3210

Closed
alex-page opened this issue Sep 1, 2020 · 1 comment · Fixed by #3328
Closed

[new DL] DropZone example, when adding a file illustration needs to be updated #3210

alex-page opened this issue Sep 1, 2020 · 1 comment · Fixed by #3328
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@alex-page
Copy link
Member

Issue summary

The illustration in the example when uploading any file that isn't an image needs to be updated.

Expected behavior

Uses the new illustration pattern.

Actual behavior

Screen Shot 2020-09-01 at 9 49 38 AM

Steps to reproduce the problem

  1. Go to the DropBox page and drag an svg file into the dropzone
  2. The image uses the old illustration
@alex-page alex-page added the Bug Something is broken and not working as intended in the system. label Sep 1, 2020
@alex-page alex-page changed the title DropZone example, when adding a file illustration needs to be updated [new DL] DropZone example, when adding a file illustration needs to be updated Sep 1, 2020
@alekmackie
Copy link

The existing note icon in Polaris Icons is used elsewhere to represent a document, so I think it fits well here, too. That way, it should also be updated automatically when we ship the filled icons.

Ideally, the content inside the dropzone would have some padding between it and the edge of the dropzone. Rough mockup to illustrate:

Screen Shot 2020-09-01 at 12 29 20 PM

@alex-page alex-page changed the title [new DL] DropZone example, when adding a file illustration needs to be updated [new DL] DropZone example, text wrapping and spacing Sep 1, 2020
@alex-page alex-page changed the title [new DL] DropZone example, text wrapping and spacing [new DL] DropZone example, when adding a file illustration needs to be updated Sep 1, 2020
@alex-page alex-page self-assigned this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants