Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CheckableButton] Border disappears on tab focus #3987

Closed
lhoffbeck opened this issue Feb 10, 2021 · 0 comments · Fixed by #3988
Closed

[CheckableButton] Border disappears on tab focus #3987

lhoffbeck opened this issue Feb 10, 2021 · 0 comments · Fixed by #3988
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@lhoffbeck
Copy link
Contributor

Issue summary

Noticed this initially in the @shopify/web admin, issue here.

On the BulkActions component, when the CheckableButton is focused, the right border disappears:

(Example from the polaris resource list with bulk actions documentation):

Screen Shot 2021-02-10 at 3 29 29 PM

Screen Shot 2021-02-10 at 2 42 10 PM

Expected behavior

Focusing checkbox shouldn't remove the right border

Actual behavior

Focusing checkbox does remove the right border

10-40-i14sa-hxl32.video.mp4

Specifications

  • Are you using the React components? (Y/N):
  • Polaris version number:
  • Browser:
  • Device:
  • Operating System:

Or run npx envinfo --system --binaries --browsers --npmPackages react,react-dom,@shopify/polaris to provide specifications on your environment including version numbers, browser, device, and operating system.

Paste the results here:

 System:
    OS: macOS 10.15.7
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 452.45 MB / 32.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.15.0 - ~/.nvm/versions/node/v10.15.0/bin/node
    Yarn: 1.13.0 - ~/.dev/yarn/v1.13.0/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Browsers:
    Chrome: 88.0.4324.150
    Chrome Canary: 90.0.4414.0
    Firefox: 85.0.1
    Firefox Developer Edition: 85.0
    Safari: 13.1.3
  npmPackages:
    react: ^16.9.0 => 16.9.0 
    react-dom: ^16.9.0 => 16.9.0 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant