Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceList Bulk Actions label is cut out under the text baseline, making some characters hard to read #4166

Closed
tszekely opened this issue May 5, 2021 · 1 comment
Labels
Bug Something is broken and not working as intended in the system. no-issue-activity untriaged

Comments

@tszekely
Copy link

tszekely commented May 5, 2021

Expected behavior

All text characters should be fully visible. Overflowing text should be hidden and not push other elements beneath the List bounds.

Actual behavior

ResourceList Bulk Actions label is cut out under the text baseline, making some characters (like g, q, y, etc.) hard to read. This is due to the combination of overflow: hidden; and line-height: 1; CSS rule combination. Moreover, the flex & overflow combination doesn't work, overflowing text will push other items over the ResourceList bounds.

First noticed the issue in our project:
image

And I can reproduce it on the Polaris demo website:
image
https://polaris.shopify.com/components/lists-and-tables/resource-list#navigation

The line-height property seems duplicated, disabling the second rule (with value 1) appears to fix the issue without visible side-effects.

.Polaris-CheckableButton {
    font-size: 1.5rem;
    font-weight: var(--p-button-font-weight,400);
    line-height: 1.6rem;
    text-transform: none;
    letter-spacing: normal;
    display: flex;
    align-items: center;
    min-height: 3.6rem;
    min-width: 3.6rem;
    margin: 0;
    padding: .7rem 1.6rem;
    line-height: 1;
    cursor: pointer;
    -webkit-user-select: none;
    user-select: none;
    text-decoration: none;
    text-align: left;
    border-radius: var(--p-border-radius-base,3px);
    width: 100%;
    background: var(--p-surface);
    box-shadow: var(--p-button-drop-shadow);
    border: 1px solid var(--p-border-neutral-subdued);
    border-top-color: var(--p-border-subdued);
    border-bottom-color: var(--p-border-shadow-subdued);
}

Specifications

  • Are you using the React components? (Y/N): Y
  • Polaris version number: 6.2.0
  • Browser: Google Chrome 90.0.4430.93
  • Device: PC
  • Operating System: Windows 10
@tszekely tszekely added the Bug Something is broken and not working as intended in the system. label May 5, 2021
@alex-page alex-page removed the group 4 label Aug 19, 2022
@github-actions
Copy link
Contributor

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's design system and dev experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. no-issue-activity untriaged
Projects
None yet
Development

No branches or pull requests

3 participants