Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polaris card implements footer action buttons in the reverse order compared to similar components #551

Closed
sivakumar-kailasam opened this issue Nov 6, 2018 · 1 comment · Fixed by #558
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@sivakumar-kailasam
Copy link
Contributor

Issue summary

Whenever any of the polaris components implement a button group with a primary & secondary action, they always have the secondary action first followed by the primary action but in case of the card component it has been implemented the other way around

Expected behavior

The secondaryFooterAction should be rendered first followed by the primaryFooterAction

Actual behavior

The primaryFooterActionis rendered before the secondaryFooterAction.

Steps to reproduce the problem

Implement a card with footer actions as shown in https://codesandbox.io/s/yvwy63yll9?module=App.js

Specifications

  • Are you using the React components? (Y/N):Y
  • Polaris version number: latest
  • Browser:All
  • Device: N/A
  • Operating System:N/A

I'd be happy to raise a PR for this if this is indeed a bug.

@dpersing
Copy link
Contributor

dpersing commented Nov 6, 2018

Hi @sivakumar-kailasam! Agreed that this definitely looks like a bug. A PR would be welcome! 🎉

@dpersing dpersing added the Bug Something is broken and not working as intended in the system. label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants