Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unsupported React Fragment syntax #1080

Merged
merged 1 commit into from Feb 21, 2019
Merged

Resolve unsupported React Fragment syntax #1080

merged 1 commit into from Feb 21, 2019

Conversation

beefchimi
Copy link
Contributor

This PR merged an unsupported React.Fragment syntax (<>...</>), which resulted in build container failures for my app.

All I have done here is convert to the supported <React.Fragment> syntax.

@beefchimi beefchimi added Bug Something is broken and not working as intended in the system. Critical labels Feb 21, 2019
@beefchimi beefchimi self-assigned this Feb 21, 2019
@BPScott BPScott temporarily deployed to polaris-react-pr-1080 February 21, 2019 16:10 Inactive
@AndrewMusgrave
Copy link
Member

I just re-ran CI 👍

@beefchimi beefchimi merged commit 9dd2ce4 into master Feb 21, 2019
@beefchimi beefchimi deleted the react-fragment-syntax branch February 21, 2019 16:36
@danrosenthal danrosenthal mentioned this pull request Feb 21, 2019
Merged
@danrosenthal danrosenthal temporarily deployed to production February 21, 2019 18:40 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvendrik kvendrik kvendrik approved these changes

@AndrewMusgrave AndrewMusgrave AndrewMusgrave approved these changes

Assignees

@beefchimi beefchimi

Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beefchimi @AndrewMusgrave @kvendrik @BPScott @danrosenthal