New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Bridge: Update to v1.3.0 #1349
Conversation
1b0720a
to
0b5e324
Compare
0b5e324
to
5846ec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃帺 Looks good! Can't wait to try it out.
@@ -34,6 +34,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f | |||
|
|||
- Bump react-utilites to remove a transitive dependency on core-js. ([#1343](https://github.com/Shopify/polaris-react/pull/1343)) | |||
|
|||
- Updated App Bridge to version 1.3.3 ([#1349](https://github.com/Shopify/polaris-react/pull/1349)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, should be 1.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! I'll put up another pr to fix it
WHY are these changes introduced?
Fixes #998
Fixes #1028
Allows apps to subscribe to redirect actions and handle its own redirects. This allows single page apps using its own routing (ex. React Router) to navigate without reloading the app.
Before (iframe is reloaded)
After (iframe is not reloaded)
Using a custom handler for app redirects
The following is an example of a component utilizing the App Bridge context from Polaris to subscribe to redirects and add its own handler.
WHAT is this pull request doing?
Update to use App Bridge v1.3.0
How to 馃帺
cd app-bridge-polaris-react-router
dev up
polaris-react
and doyarn build-consumer app-bridge-test-apps/app-bridge-polaris-react-router
.