[v4][ContextualSaveBar] Remove withContext #1498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
force-pushed
the
csr-dep-hoc
branch
from
601b402
to
9ba173e
Compare
AndrewMusgrave
added
the
馃Skip Changelog
AndrewMusgrave
commented
May 15, 2019
| withContext<Props, WithAppProviderProps, FrameContextType>( | ||
| FrameContext.Consumer, | ||
| ), | ||
| withAppProvider(), |
There was a problem hiding this comment.
This was never being used
AndrewMusgrave
force-pushed
the
csr-dep-hoc
branch
from
9ba173e
to
57d5742
Compare
|
@dleroux This should hold up against the rendering issue but let's test tomorrow to be sure |
AndrewMusgrave
force-pushed
the
csr-dep-hoc
branch
from
57d5742
to
b2dd51b
Compare
AndrewMusgrave
force-pushed
the
csr-dep-hoc
branch
from
b2dd51b
to
c340b4d
Compare
AndrewMusgrave
commented
May 28, 2019
| alignContentFlush, | ||
| }); | ||
| }, | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Frame context next changes so we don't need it as a dep
AndrewMusgrave
force-pushed
the
csr-dep-hoc
branch
from
c340b4d
to
26f3ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Part of #1484
WHAT is this pull request doing?
I'm converting ContextualSaveBar to a functional component and removing
withContextHow to 馃帺
Tests / percy / development server