New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Add drop zone component a11y docs and edit description #2243
Conversation
No changes馃挦 Potential splash zone of changes introduced to No significant changes to This comment automatically updates as changes are made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some language tweaks based on a recent update that I should have caught sooner. Let me know if I can provide some more context. I'm also happy to update the PR if that's easier!
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃帀 Looks great! Thank you, @sadiesaurus.
WHY are these changes introduced?
polaris-react
docs and in the style guide.WHAT is this pull request doing?
UNRELEASED.md
How to 馃帺
master
frompolaris-styleguide
to get the changes that support the accessibility section.polaris-react
and run the instructions for testing in a consuming project.polaris-styleguide
tab, rundev up && dev start
.Screenshots
FYI @dpersing 鉂わ笍