Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Add drop zone component a11y docs and edit description #2243

Merged
merged 7 commits into from Oct 9, 2019

Conversation

sadiesaurus
Copy link
Contributor

WHY are these changes introduced?

  • Adds accessibility guidance for the drop zone component, to appear in polaris-react docs and in the style guide.
  • Edits the drop zone component description

WHAT is this pull request doing?

  • Adds accessibility documentation for the drop zone component (web only)
  • Adds an entry to UNRELEASED.md

How to 馃帺

  1. Check out master from polaris-styleguide to get the changes that support the accessibility section.
  2. In another Terminal tab or window, check out this branch from polaris-react and run the instructions for testing in a consuming project.
  3. In the polaris-styleguide tab, run dev up && dev start.
  4. View changes after examples and props:

Screenshots

Screenshot of the new description for the drop zone component

Screenshot of the drop zone web only accessibility guidelines

FYI @dpersing 鉂わ笍

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2019

No changes

馃挦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.


This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@dpersing dpersing self-requested a review October 4, 2019 20:19
Copy link
Contributor

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some language tweaks based on a recent update that I should have caught sooner. Let me know if I can provide some more context. I'm also happy to update the PR if that's easier!

src/components/DropZone/README.md Outdated Show resolved Hide resolved
src/components/DropZone/README.md Outdated Show resolved Hide resolved
src/components/DropZone/README.md Outdated Show resolved Hide resolved
src/components/DropZone/README.md Outdated Show resolved Hide resolved
sadiesaurus and others added 5 commits October 4, 2019 13:29
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Co-Authored-By: Devon Persing <devon.persing@shopify.com>
Copy link
Contributor

@dpersing dpersing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀 Looks great! Thank you, @sadiesaurus.

@sadiesaurus sadiesaurus merged commit 7c6c662 into master Oct 9, 2019
@sadiesaurus sadiesaurus deleted the dropzone-component-a11y-docs branch October 9, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants