Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextField] Add required prop to TextField #3514

Closed
wants to merge 3 commits into from

Conversation

dkershner6
Copy link

WHY are these changes introduced?

Fixes #3512

Easy, powerful change.

WHAT is this pull request doing?

HTML Input elements have a required prop to ensure a value is provide, this allows it to be used with Polaris' TextField.

@ghost
Copy link

ghost commented Oct 18, 2020

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines.

@ghost ghost added the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Oct 18, 2020
@ghost ghost removed the cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. label Oct 18, 2020
@alex-page alex-page force-pushed the master branch 2 times, most recently from 4eab9e5 to 9e09ba7 Compare January 15, 2021 05:17
Base automatically changed from master to main January 21, 2021 15:38
Tom-Bonnike
Tom-Bonnike previously approved these changes Jan 27, 2021
@Tom-Bonnike Tom-Bonnike dismissed their stale review January 27, 2021 15:00

NVM need to make some changes there shouldn’t be a package-lock diff. :)

@Tom-Bonnike
Copy link
Contributor

For reference… the Polaris team apparently doesn’t want this change so this PR probably won’t get merged. 😕

@dkershner6
Copy link
Author

For reference… the Polaris team apparently doesn’t want this change so this PR probably won’t get merged. 😕

That's...odd. This is definitely accessibility friendly...

Oh well, ill leave it here until someone definitively says something.

@chloerice
Copy link
Member

Hey @dkershner6 thank you for contributing to the discussion around this issue. I'm going to close this PR in lieu of #4119

@chloerice chloerice closed this Jun 13, 2022
@bakura10
Copy link

@chloerice , can this issue be reconsidered? It might have been a good decision two years ago, but in 2024 Shopify is pushing hard Remix for app development. Remix's main selling point is to embrace the web built-in features and, especially, forms. Being able to add the required attribute to input easily would allow to easily use built-in client-side validation and improve merchant user experience.

@chloerice
Copy link
Member

Hey @bakura10 👋🏽 There are API updates planned and required will be supported on all inputs when it ships, but it will be a while before it does. Stay tuned 🙏🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextField - Pass along required prop to input
4 participants