New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Add required prop to TextField #3514
Conversation
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
4eab9e5
to
9e09ba7
Compare
NVM need to make some changes there shouldn’t be a package-lock diff. :)
For reference… the Polaris team apparently doesn’t want this change so this PR probably won’t get merged. 😕 |
That's...odd. This is definitely accessibility friendly... Oh well, ill leave it here until someone definitively says something. |
2c6e842
to
d2611d6
Compare
c630336
to
ea3c495
Compare
Hey @dkershner6 thank you for contributing to the discussion around this issue. I'm going to close this PR in lieu of #4119 |
@chloerice , can this issue be reconsidered? It might have been a good decision two years ago, but in 2024 Shopify is pushing hard Remix for app development. Remix's main selling point is to embrace the web built-in features and, especially, forms. Being able to add the |
Hey @bakura10 👋🏽 There are API updates planned and |
WHY are these changes introduced?
Fixes #3512
Easy, powerful change.
WHAT is this pull request doing?
HTML Input elements have a required prop to ensure a value is provide, this allows it to be used with Polaris' TextField.