New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Link] underlined by default and add removeUnderline prop #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃煛 This pull request modifies 6 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected. Details:All files potentially affected (total: 5)馃搫
|
alex-page
reviewed
Dec 21, 2020
alex-page
force-pushed
the
link-default-underline
branch
2 times, most recently
from
January 20, 2021 04:50
f41c8f9
to
663fb37
Compare
alex-page
changed the title
[Link] Make link component underline by default and add removeUnderline prop
[Link] underlined by default and add removeUnderline prop
Jan 20, 2021
alex-page
force-pushed
the
link-default-underline
branch
from
January 20, 2021 05:13
e539e26
to
c46253b
Compare
alex-page
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in a good starting place, happy to finesse the content in iterations.
Co-authored-by: Ashwin Narayanan <ashwin.narayanan@shopify.com>
alex-page
force-pushed
the
link-default-underline
branch
from
January 20, 2021 05:19
5475246
to
3279f19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
These changes are introduced after discussions regarding if the link component should be underline by default (#3697), and if color alone is able to convey controls (https://github.com/Shopify/polaris-ux/issues/455). It was determined that making the link component underline by default makes the component more accessible when color is the only way to convey a link is interactive. It was also determined that it would be easier to add a 'removeUnderline' prop if the underline was not required, as opposed to adding an underline prop every time.
Fixes Shopify/polaris-ux#455
WHAT is this pull request doing?
This pull request makes the link component underline by default, and adds a 'removeUnderline' prop that removes the underline on the link.
This screenshot shows the Link component, which is underline by default.
This screenshot shows the Link component when the removeUnderline prop is added.
How to 馃帺
馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:馃帺 checklist
README.md
with documentation changes