Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail icon subdued #3846

Merged
merged 3 commits into from Jan 15, 2021
Merged

Thumbnail icon subdued #3846

merged 3 commits into from Jan 15, 2021

Conversation

alex-page
Copy link
Member

WHY are these changes introduced?

Changes thumbnail icon color subdued, as referenced in https://github.com/Shopify/web/issues/32928

WHAT is this pull request doing?

Makes thumbnail icon color subdued, as referenced in https://github.com/Shopify/web/issues/32928

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@alex-page alex-page added the 馃Skip Changelog Causes CI to ignore changelog update check. label Jan 15, 2021
@alex-page alex-page self-assigned this Jan 15, 2021
@alex-page alex-page merged commit f04192f into master Jan 15, 2021
@alex-page alex-page deleted the thumbnail-icon-subdued branch January 15, 2021 03:13
@@ -39,5 +39,5 @@
max-width: 100%;
max-height: 100%;
@include recolor-icon(currentColor);
color: var(--p-icon, color('ink', 'lighter'));
color: var(--p-icon-subdued);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on master. Do we still need that fallback for when new DL is off?

Copy link
Member Author

@alex-page alex-page Jan 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Brb fixing master 馃檲

alex-page pushed a commit that referenced this pull request Jan 15, 2021
alex-page pushed a commit that referenced this pull request Jan 15, 2021
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants