Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sheet] Add required aria label #3852

Merged
merged 20 commits into from Jan 15, 2021
Merged

[Sheet] Add required aria label #3852

merged 20 commits into from Jan 15, 2021

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Jan 15, 2021

WHY are these changes introduced?

Fixes accessibility issue in #3749

WHAT is this pull request doing?

  • Add required ariaLabel for sheet

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@alex-page alex-page changed the base branch from master to version-6.0.0 January 15, 2021 15:30
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2021

馃煝 This pull request modifies 5 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃З src/components/Filters/Filters.tsx (total: 0)

Files potentially affected (total: 0)

馃搫 src/components/Sheet/README.md (total: 0)

Files potentially affected (total: 0)

馃З src/components/Sheet/Sheet.tsx (total: 1)

Files potentially affected (total: 1)

馃З src/components/Sheet/tests/Sheet.test.tsx (total: 0)

Files potentially affected (total: 0)

@alex-page alex-page changed the title [Sheet] required aria label [Sheet] Add required aria label Jan 15, 2021
Comment on lines +7 to +8
- Remove `light` property from `Tooltip` as it now defaults to a light background ([#3846](https://github.com/Shopify/polaris-react/pull/3846))
- Made `title` property required in `Modal` for accessibility label, added `hideTitle` property ([#3803](https://github.com/Shopify/polaris-react/pull/3803))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃敟?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the links where there twice, so I removed the duplicated links:

(#3803) (#3803)

src/components/Sheet/Sheet.tsx Show resolved Hide resolved
@alex-page alex-page merged commit 7ffe0cd into version-6.0.0 Jan 15, 2021
@alex-page alex-page deleted the sheet-aria-label branch January 15, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants