Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated features #3884

Merged
merged 5 commits into from Jan 19, 2021
Merged

Remove deprecated features #3884

merged 5 commits into from Jan 19, 2021

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Jan 19, 2021 •
edited

WHY are these changes introduced?

Removing deprecated features in a major version

WHAT is this pull request doing?

  • Remove Button/UnstyledButton ariaPressed: This was replaced by the pressed prop in Polaris v4.7.0
  • Remove Button stretchContent prop: This was replaced by combining using fullWidth and textAlign=left in Polaris v5.13.0
  • Remove Popover/PopoverOverlay preventAutofocus prop: This was replaced by autofocusTarget="none" in 5.13.0

The FilterControl component remains deprecated but present as web never prioritized ripping out its one remaining but knotty usage in web.

@BPScott
Remove Button/UnstyledButton ariaPressed
ed50218 
This was replaced by the `pressed` prop in Polaris v4.7.0
@BPScott
Remove Button stretchContent prop
5c2d9d5 
This was replaced by combining using `fullWidth` and `textAlign=left` in
Polaris v5.13.0
@BPScott
Remove Popover/PopoverOverlay preventAutofocus prop
72592b2 
This was replaced by `autofocusTarget="none"` in 5.13.0
@BPScott
Add changelog items
02e7061
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2021 •
edited

🔴 This pull request modifies 14 files and might impact 112 other files. Because this is a larger than average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 112)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Autocomplete/components/ComboBox/ComboBox.tsx (total: 1)

Files potentially affected (total: 1)

🧩 src/components/Autocomplete/components/ComboBox/tests/ComboBox.test.tsx (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Button/Button.scss (total: 55)

Files potentially affected (total: 55)

🧩 src/components/Button/Button.tsx (total: 54)

Files potentially affected (total: 54)

📄 src/components/Button/README.md (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Button/tests/Button.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Popover/Popover.tsx (total: 57)

Files potentially affected (total: 57)

🧩 src/components/Popover/components/PopoverOverlay/PopoverOverlay.tsx (total: 58)

Files potentially affected (total: 58)

🧩 src/components/Popover/components/PopoverOverlay/tests/PopoverOverlay.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/Popover/tests/Popover.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/components/UnstyledButton/UnstyledButton.tsx (total: 56)

Files potentially affected (total: 56)

🧩 src/components/UnstyledButton/tests/UnstyledButton.test.tsx (total: 0)

Files potentially affected (total: 0)

🧩 src/types.ts (total: 112)

Files potentially affected (total: 112)

@BPScott BPScott merged commit 66978e1 into version-6.0.0 Jan 19, 2021
@BPScott BPScott deleted the remove-deprecated-features branch January 19, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-page alex-page alex-page approved these changes

@kyledurand kyledurand Awaiting requested review from kyledurand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BPScott @alex-page