Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fallbacks, remove unused vars and mixins #3889

Merged
merged 4 commits into from Jan 20, 2021

Conversation

alex-page
Copy link
Member

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@alex-page alex-page added the 馃Skip Changelog Causes CI to ignore changelog update check. label Jan 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

馃煛 This pull request modifies 8 files and might impact 15 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 15)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃帹 src/components/Choice/Choice.scss (total: 8)

Files potentially affected (total: 8)

馃帹 src/components/DropZone/components/FileUpload/FileUpload.scss (total: 2)

Files potentially affected (total: 2)

馃帹 src/components/Frame/Frame.scss (total: 1)

Files potentially affected (total: 1)

馃帹 src/components/TopBar/components/SearchDismissOverlay/SearchDismissOverlay.scss (total: 3)

Files potentially affected (total: 3)

馃帹 src/components/VideoThumbnail/VideoThumbnail.scss (total: 1)

Files potentially affected (total: 1)

馃帹 src/styles/shared/_skeleton.scss (total: 0)

Files potentially affected (total: 0)

馃帹 src/styles/shared/_typography.scss (total: 0)

Files potentially affected (total: 0)

src/styles/shared/_skeleton.scss Outdated Show resolved Hide resolved
src/styles/shared/_typography.scss Show resolved Hide resolved
@alex-page alex-page merged commit 3b45683 into version-6.0.0 Jan 20, 2021
@alex-page alex-page deleted the add-missing-color branch January 20, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants