Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disclosure icon color with prop #3926

Merged
merged 4 commits into from Jan 27, 2021

Conversation

alex-page
Copy link
Member

WHY are these changes introduced?

Fixes #3925

WHAT is this pull request doing?

The icon color was set in SASS and incorrect on the icon. This removes the SASS and provides the color through the Icon component.

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@alex-page alex-page self-assigned this Jan 27, 2021
@alex-page alex-page added 馃Skip Changelog Causes CI to ignore changelog update check. and removed 馃Skip Changelog Causes CI to ignore changelog update check. labels Jan 27, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2021

馃煝 This pull request modifies 3 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃帹 src/components/Tabs/Tabs.scss (total: 1)

Files potentially affected (total: 1)

馃З src/components/Tabs/Tabs.tsx (total: 0)

Files potentially affected (total: 0)

Alex Page and others added 2 commits January 27, 2021 12:39
Co-Authored-By: Ben Scott <227292+BPScott@users.noreply.github.com>
@alex-page alex-page merged commit 452210c into main Jan 27, 2021
@alex-page alex-page deleted the change-disclosure-icon-color-with-prop branch January 27, 2021 23:25
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for tabs disclosure has sass to apply subdued color, should just use subdued icon
2 participants