Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frame]Add focus ring to mobile navigation #3936

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

AndrewMusgrave
Copy link
Member

WHY are these changes introduced?

Only the base styles are being applied to the mobile nav dismiss button.

WHAT is this pull request doing?

  • Add focus styles

Screenies

Before After
Screen Shot 2021-01-28 at 3 08 57 PM Screen Shot 2021-01-28 at 3 06 17 PM

@AndrewMusgrave AndrewMusgrave marked this pull request as ready for review January 28, 2021 20:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2021

🟢 This pull request modifies 2 files and might impact 1 other files.

Details:
All files potentially affected (total: 1)
📄 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

🎨 src/components/Frame/Frame.scss (total: 1)

Files potentially affected (total: 1)

Copy link
Contributor

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@AndrewMusgrave AndrewMusgrave merged commit 29bd2f3 into main Feb 5, 2021
@AndrewMusgrave AndrewMusgrave deleted the frame-navigation-focus-ring branch February 5, 2021 17:42
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
* Add focus ring to mobile navigation

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants