Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Link.scss #3943

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Update Link.scss #3943

merged 1 commit into from
Jan 29, 2021

Conversation

alex-page
Copy link
Member

WHY are these changes introduced?

Fixes https://github.com/Shopify/web/pull/36923#issuecomment-769854522

WHAT is this pull request doing?

This lightens the border when printing to address the issue raised here

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @ HYPD, @ mirualves, @ sarahill, or @ ry5n to update the Polaris UI kit

@alex-page alex-page merged commit 488c1c8 into main Jan 29, 2021
@alex-page alex-page deleted the subdued-border-print branch January 29, 2021 16:11
@github-actions
Copy link
Contributor

🟡 This pull request modifies 1 files and might impact 5 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 5)
🎨 src/components/Link/Link.scss (total: 5)

Files potentially affected (total: 5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants