Convert some simple components to be functional #3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Connected Item - Filter ConnectedFilterControl Item - List - Tabs List
BPScott
force-pushed
the
easy-hookifies
branch
from
b2996a0
to
d1dbc79
Compare
kyledurand
approved these changes
Feb 3, 2021
src/components/List/List.tsx
Outdated
| @@ -1,4 +1,4 @@ | |||
| import React, {PureComponent} from 'react'; | |||
| import React, {NamedExoticComponent} from 'react'; | |||
There was a problem hiding this comment.
Were you planning on doing something with this?
There was a problem hiding this comment.
ooh whoops. That was a hangover from a slightly different trick to tempt the types into playing nice that wasn't needed. Removed!
This was referenced Mar 18, 2021
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
- Connected Item - Filter ConnectedFilterControl Item - List - Tabs List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Death to class components!
WHAT is this pull request doing?
Converting the following components to be functional components: