[ResourceItem] Add dataHref prop #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
|
🟢 This pull request modifies 2 files and might impact 1 other files. Details:All files potentially affected (total: 1)🧩
|
alex-page
approved these changes
Feb 4, 2021
|
🎉 Thanks for your contribution to Polaris React! |
This was referenced Mar 18, 2021
sylvhama
pushed a commit
that referenced
this pull request
Mar 26, 2021
* Adding dataHref prop to ResourceItem and updating tests * Updating test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To enable prefetching when a user hovers over the
ResourceItemthrough adata-hrefattribute on the parentlitag.Fixes https://github.com/Shopify/marketing-technology/issues/6390. Also referenced here @billycai
WHAT is this pull request doing?
Adds the
dataHrefprop toResourceItem. If a string is provided, the mainlitag will render adata-hrefattribute. Also adds two tests to check functionality.