Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] Add optional removeUnderline prop #3998

Merged
merged 1 commit into from
Feb 12, 2021
Merged

[Button] Add optional removeUnderline prop #3998

merged 1 commit into from
Feb 12, 2021

Conversation

carolopolo
Copy link
Contributor

@carolopolo carolopolo commented Feb 11, 2021 •
edited
Loading

WHY are these changes introduced?

  • To cover use cases for consumers who need to use a button (for interactive purposes that don't include linking to something), and want to render a truly plain, monochrome button with no underline

WHAT is this pull request doing?

  • Adds optional removeUnderline prop to <Button/>
  • Removes underline from the button text, including on on hover/focus

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';

import {Button, Page, Stack} from '../src';

export function Playground() {
  return (
    <Page title="Compare the following two buttons">
      <Stack vertical>
        <Button monochrome plain removeUnderline>
          New plain, monochrome button with no underline
        </Button>
        <Button monochrome plain>
          Existing plain, monochrome button
        </Button>
      </Stack>
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@carolopolo carolopolo self-assigned this Feb 11, 2021
@carolopolo carolopolo force-pushed the button/add-removeUnderLine-prop branch from 6245d55 to 263bb2a Compare February 11, 2021 23:18
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2021 •
edited
Loading

馃煛 This pull request modifies 4 files and might impact 56 other files. This is an average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 56)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃帹 src/components/Button/Button.scss (total: 56)

Files potentially affected (total: 56)

馃З src/components/Button/Button.tsx (total: 55)

Files potentially affected (total: 55)

馃З src/components/Button/tests/Button.test.tsx (total: 0)

Files potentially affected (total: 0)

@carolopolo carolopolo changed the title add removeUnderline prop to Button [Button] Add optional removeUnderline prop Feb 11, 2021
@carolopolo carolopolo force-pushed the button/add-removeUnderLine-prop branch from 263bb2a to 922d950 Compare February 11, 2021 23:31
@carolopolo carolopolo marked this pull request as ready for review February 11, 2021 23:32
@carolopolo carolopolo force-pushed the button/add-removeUnderLine-prop branch 2 times, most recently from 42e9add to 04dceec Compare February 12, 2021 19:03
@carolopolo carolopolo force-pushed the button/add-removeUnderLine-prop branch from 04dceec to 7118c9f Compare February 12, 2021 19:22
@carolopolo carolopolo merged commit 993e38f into main Feb 12, 2021
@carolopolo carolopolo deleted the button/add-removeUnderLine-prop branch February 12, 2021 19:32
This was referenced Mar 18, 2021
Closed
Closed
sylvhama pushed a commit that referenced this pull request Mar 26, 2021
@carolopolo @sylvhama
add removeUnderline prop to Button (#3998)
d439461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanhamel4 jonathanhamel4 jonathanhamel4 approved these changes

@alex-page alex-page alex-page approved these changes

@loic-d loic-d Awaiting requested review from loic-d

Assignees

@carolopolo carolopolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carolopolo @jonathanhamel4 @alex-page