[ActionList] Remove focus ring on click #3649 #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃憢 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven鈥檛 already, please check out the contributing guidelines. |
happykoder
force-pushed
the
3649-focus-ring-onclick
branch
from
a3ed8f1
to
313a2e1
Compare
kyledurand
requested changes
Mar 4, 2021
happykoder
force-pushed
the
3649-focus-ring-onclick
branch
from
313a2e1
to
574a777
Compare
kyledurand
reviewed
Mar 5, 2021
kyledurand
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Getting closer!
Because these elements have changed to inline (thanks for doing this btw) it breaks the layout of action list items with helper text
Should look like
So we'll need to add some css i.e. display: block to these spans that were changed in order to preserve this layout.
happykoder
force-pushed
the
3649-focus-ring-onclick
branch
from
574a777
to
9fad616
Compare
update unrelease.md
happykoder
force-pushed
the
3649-focus-ring-onclick
branch
from
25f186e
to
0ba34aa
Compare
kyledurand
reviewed
Mar 5, 2021
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
dleroux
approved these changes
Mar 8, 2021
kyledurand
approved these changes
Mar 8, 2021
|
Awesome! |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #3649
WHAT is this pull request doing?
Applied the same approach used on Polaris Button component.
How to 馃帺
馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines
ActionList.focus-ring.demo.mov
馃帺 checklist
README.mdwith documentation changes