Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive color to Icon #4112

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Add interactive color to Icon #4112

merged 2 commits into from
Apr 16, 2021

Conversation

kyledurand
Copy link
Contributor

WHY are these changes introduced?

Noticed a gap in our icon colours while working on online store stuff

WHAT is this pull request doing?

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

馃帺 checklist

  • Tested on mobile
  • Tested on multiple browsers
  • Tested for accessibility
  • Updated the component's README.md with documentation changes
  • Tophatted documentation changes in the style guide
  • For visual design changes, pinged one of @鈥奌YPD, @鈥妋irualves, @鈥妔arahill, or @鈥妑y5n to update the Polaris UI kit

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2021 •
edited

馃敶 This pull request modifies 4 files and might impact 88 other files. Because this is a larger than average splash zone for a change, remember to tophat areas that could be affected.

Details:
All files potentially affected (total: 88)
馃搫 UNRELEASED.md (total: 0)

Files potentially affected (total: 0)

馃帹 src/components/Icon/Icon.scss (total: 88)

Files potentially affected (total: 88)

馃З src/components/Icon/Icon.tsx (total: 87)

Files potentially affected (total: 87)

馃З src/components/Icon/tests/Icon.test.tsx (total: 0)

Files potentially affected (total: 0)

@kyledurand kyledurand force-pushed the add-interactive-color-variant-to-icon branch from 9b09037 to c9f8e44 Compare April 9, 2021 02:43
@kyledurand kyledurand force-pushed the add-interactive-color-variant-to-icon branch from c9f8e44 to c31c23b Compare April 9, 2021 02:44
@nicolleromero nicolleromero mentioned this pull request Apr 16, 2021
Merged
alex-page
alex-page approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kyledurand kyledurand merged commit 1ce2267 into main Apr 16, 2021
@kyledurand kyledurand deleted the add-interactive-color-variant-to-icon branch April 16, 2021 18:48
kyledurand
kyledurand commented Nov 25, 2021
View reviewed changes
src/components/Icon/tests/Icon.test.tsx
'The primary variant does not have a supported backdrop color',
);
});
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did I add tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-page alex-page alex-page approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyledurand @alex-page