[IndexTable] update sticky column hover styles #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃煝 This pull request modifies 2 files and might impact 1 other files. Details:All files potentially affected (total: 1)馃搫
|
kyledurand
approved these changes
Apr 12, 2021
| .TableCell-first + .TableCell { | ||
| background-color: var( | ||
| --p-surface-selected-hovered, | ||
| color('sky', 'lighter') |
There was a problem hiding this comment.
We can 馃敟 this now. No need for fallbacks within this repo
There was a problem hiding this comment.
oh sick. looks like there's a bunch of that in this component, i'll open a cleanup PR and tag you on it :)
There was a problem hiding this comment.
opened #4117 for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The sticky column background styles were more specific than the hover styles, added a line of CSS so it looks consistent:
馃憖 Before 馃憖
before.mp4
馃憖 After 馃憖
after.mp4
WHAT is this pull request doing?
Adds some specificity. (technically the same level as the css that sets the cell bg to white but it's later in the file)
馃帺 checklist
README.mdwith documentation changes