[Frame/Loading] Fix async setState calls #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMusgrave
commented
May 4, 2021
| @@ -1,14 +1,15 @@ | |||
| import React, {useEffect, useState} from 'react'; | |||
There was a problem hiding this comment.
I would have loved to write a test for this, but I can't get the component in the proper state.
There was a problem hiding this comment.
Yeah, tests would be nice but I think this is pretty straightforward.
|
馃煝 This pull request modifies 2 files and might impact 1 other files. Details:All files potentially affected (total: 1)馃搫
|
dleroux
approved these changes
May 4, 2021
AndrewMusgrave
force-pushed
the
fix-async-loading
branch
2 times, most recently
from
2c422a6
to
161e094
Compare
changelog
AndrewMusgrave
force-pushed
the
fix-async-loading
branch
from
161e094
to
865a0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Loading can call set state after the component has unmounted
WHAT is this pull request doing?
Adding an isMounted check
How to 馃帺
Unfortunately it's very hard to reproduce the error. @dleroux did you want to check it in off your branch?