Remove unitless calc addition for when postcss-calc is not included #4234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Ben Scott 227292+BPScott@users.noreply.github.com
WHY are these changes introduced?
Fixes #4232
WHAT is this pull request doing?
Unitless calc was breaking when users did not provide postcss-calc as a plugin. This fixes the outline on components like
<Button plain>
where the output of the focusring mixin wascalc(0 + 1rem)
.How to 馃帺
Remove this from
./storybook/main.js
https://github.com/Shopify/polaris-react/blob/9081df8bde8c682240fbc1cccba35bb5dbdd6d08/.storybook/main.js#L57-L63
Then open the plain button example.
馃帺 checklist
README.md
with documentation changes