Replace duration() function with tokens #4699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgriffee
requested review from
aveline,
yurm04,
kyledurand,
alex-page and
aaronccasanova
size-limit report
|
|
I'm noticing that Chromatic is detecting UI changes but I'm not sure what is causing those yet...The same UI tests also seem to be affected in #4698 |
alex-page
approved these changes
Nov 23, 2021
alex-page
reviewed
Nov 23, 2021
aaronccasanova
approved these changes
Nov 24, 2021
alex-page
reviewed
Nov 24, 2021
alex-page
reviewed
Nov 24, 2021
alex-page
reviewed
Nov 24, 2021
kyledurand
reviewed
Nov 24, 2021
This was referenced Feb 4, 2022
sam-b-rose
added a commit
that referenced
this pull request
Feb 15, 2022
* Kebabcase token fix (#4683) * Remove capital letter grouping ZIndex = z-index * Replace font weight values with tokens (#4668) * Add font-weight tokens * Replace font-weight: 400 with token * Replace font-weight: 500 with token * Replace font-weight: 600 with token * Replace font-weight: 700 with token * Update UNRELEASED.md * Fix formatting of UNRELEASED * Remove reverted entries in UNRELEASED * Regenerate colordocs * Remove duplicate entry in UNRELEASED Co-authored-by: Alex Page <hi@alexpage.dev> * Remove misc tokens (#4686) * Revert revert to remove misc tokens * Update UNRELEASED.md * Regenerate colordocs * Remove filter sass function (#4676) * Remove sass filter function file * Remove sass filter function imports * Remove last instance of filter function * Update UNRELEASED.md * Fix UNRELEASED formatting Co-authored-by: Alex Page <hi@alexpage.dev> * Remove skeleton motion (#4462) * Remove skeleton motion and skeleton-shimmer * Remove custom and unnecessary font weight properties (#4687) * Remove tokens * Remove unnecessary properties TextField Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Update UNRELEASED.md Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Add UNRELEASED-v8 * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * removing color sass function (#4696) * Update UNRELEASED-v8.md * feat: Simplify ThemeProvider (#4642) * Update tokens.ts * Remove color-multiply scss function (#4715) Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> * Move logo from ThemeProvider to Frame (#4667) * Move logo from ThemeProvider to Frame * Remove unused eslint disable * Update test name to reflect dark scheme * Update src/components/Frame/Frame.tsx Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * re-word topbar test Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Rename designTokens directory to tokens (#4721) * Remove src/utilities/theme/* and color system docs (#4716) * 4721 cleanup (#4724) * Replace duration() function with tokens (#4699) * Replace easing() function with tokens (#4698) * Update Navigation.tsx (#4730) * docs: Update migration guide with ThemeProvider changes (#4692) * feat: Remove prefers-color-scheme dark (#4731) * [Frame] Re-add offset (#4727) * [Frame] Add offset back * add unreleased * Switch to setRootProperty for items that may render outside of Frame * Update index.ts (#4744) * [SkeletonPage] Remove secondaryAction (#4742) * [Page] Remove thumbnail prop (#4743) * 🚧 Spacing tokens (#4691) * Create spacing tokens * replace instances of spacing() * replace instances of spacing() * Update stack spacing Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Replaces instances of spacing() * Prefix locally scoped custom properties * Update ActionList.scss * replace instances of spacing() * replace instances of spacing() * replace more instances of spacing() * Add spacing tokens after update * replace instances of spacing() * replaces instances of spacing() * replace instances of spacing() * 👕 * remove the last few instances of spacing() Co-Authored-By: Alex Page <19199063+alex-page@users.noreply.github.com> * Update Banner.scss * Update ButtonGroup.scss * Update Navigation.scss * Update Banner.scss * Update _layout.scss * Update CheckableButton.scss * Update TooltipOverlay.scss * Update IndexTable.scss * Fix index table small screen view * 🤷♀️ * Update build-validate.js Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> * Remove `px()` function from public sass (#4751) * Remove px() function from public sass * Update UNRELEASED-v8.md * Cleanup set-root-property.ts (#4752) * Update set-root-property.ts Co-Authored-By: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Fix optional node * Rename styleNode to element Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Move z-indexes to tokens (#4753) * Clean up z-indexes * Remove z-index() * Update UNRELEASED-v8.md * Update src/components/Frame/components/ToastManager/ToastManager.scss * Update src/components/TopBar/components/SearchField/SearchField.scss * Update src/tokens/_z-index.ts * Remove legacy tokens * Fix z-index typo on index table (#4767) * Redefine z-index tokens (#4766) * Cleanup component level custom properties (#4768) * Cleanup component level custom properties * Update src/components/ActionList/ActionList.scss Co-authored-by: Alex Page <hi@alexpage.dev> * --pc-color-picker * Fix button * Fix spacing Co-authored-by: Alex Page <hi@alexpage.dev> * Remove unused custom properties (#4770) * Remove unused custom properties * Add to unreleased * Remove `rem()` function from public sass (#4761) * Update UNRELEASED-v8.md * remove instances of rem() (#4769) * remove rem() sass function * rename component level custom property Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Rename misc custom properties (#4774) * Move border-radius custom properties to tokens (#4763) * Remove --p-text-field-focus-ring-border-radius * Move legacy border tokens to new file * Alphabetize tokens * Create tokens to replace border-radius function * Move border tokens other than radius back to legacy tokens * Revert ordering of legacy token file * Revert ordering of legacy token file * Add border to token tests * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Remove border-radius() tokens * Update UNRELEASED-v8.md * Reorder token values * Remove unused token value * Rename component custom properties Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Replace any instances of border-radius: 50% with token * Rename component custom properties Rename component custom properties * Rename border token file to shape * Update UNRELEASED-v8.md * Remove custom property that is not used * Replace calc() with token * Replace calc() with token * Fix token naming and replacement scope * Make custom property naming more specific * Make custom property naming more specific * Make custom property naming more specific * Make custom property naming more specific * Fix typo * Fix custom property mixup * Fix bug with rem() Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Rework and rename tokens Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Replace space token with border radius token * Replace border-radius 100% on square elements with equivalent token * Replace custom value with token * Fix lint styling issues * Rework naming * Fix RangeSlider pseudo element styling issues Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Replace hardcoded spacing values with tokens (#4775) * Update Banner.scss Co-Authored-By: Sara Hill <sarashill22@gmail.com> * Update hardcoded spacing values to tokens Co-Authored-By: Sara Hill <sarashill22@gmail.com> * Update UNRELEASED-v8.md * 👕 * 🤷♀️ * Replace padding that was accidentally removed 🙊 * Update IndexTable.scss Co-Authored-By: Laura Griffee <21976492+lgriffee@users.noreply.github.com> Co-authored-by: Sara Hill <sarashill22@gmail.com> Co-authored-by: Laura Griffee <21976492+lgriffee@users.noreply.github.com> * Add duration token values between 0 and 500 with 50ms increments (Duration Tokens Phase 1) (#4781) * Add missing duration values between 0 and 500 with 50ms increments * Replace any hardcoded values with new tokens * Update README.md * Remove unnecessary motion legacy tokens * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Align easing tokens and values with CSS defaults (Easing Tokens Phase 1) (#4790) * Update the values of ease-in and ease-out * Add ease-in-out and linear tokens * Remove ease-excite token * Update UNRELEASED-v8.md * Bump node to v16 (#4778) * Bump node to v16 * Bump @types/node * bump node-sass, sass-loader * add engines entry to package.json * Remove unused eslint disable, add jsx flag to tsconfig * bump size-limit-action, specify node-version * Remove engines for now, incompatible with size-limit-action * fix lint warnings, add engines * remove jsx flag * wrong action version * Changing `TextContainer` custom properties (#4799) * updated unreleased * updating custom property name * Update UNRELEASED.md * Set root font size to 100% (#4784) * Set root font size to 100% * Convert rem values to px * try a fix for chromatic diffs 🧪 * Update rem values for chromatic snapshots * Update rem values for Chromatic snapshots * Use rems in tokens (#4808) * Use rems in tokens * revert settings.json change * Remove @shopify/polaris-tokens (#4728) Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> * Update root font size (#4794) * Update root font size * try a fix for chromatic diffs 🧪 * Update rem values for chromatic snapshots * Update rem values for Chromatic snapshots * Update token values to px * Update rem values to px * Update rems to px * Update px to rem * Update UNRELEASED.md * Bump node to v16 (#4778) * Bump node to v16 * Bump @types/node * bump node-sass, sass-loader * add engines entry to package.json * Remove unused eslint disable, add jsx flag to tsconfig * bump size-limit-action, specify node-version * Remove engines for now, incompatible with size-limit-action * fix lint warnings, add engines * remove jsx flag * wrong action version * Replace border-radius() function with tokens (#4793) * Clean up unnecessary interpolation Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Rename border radius 50% token for clarity Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Burn custom property in favor of token Co-Authored-By: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Update UNRELEASED-v8.md * Add temporary tokens to replace border-radius() values * Replace border-radius() with temp token * Replace border-radius(large) with temp token * Remove border-radius() function file and imports * Test visual regression for changing border-radius-base from 3px to 2px * Make a huge change to see if regression testing is working * Make an even more massive change just to double check regression testing * Revert all changes to for regression testing * Test visual regression for changing border-radius-base from 3px to 2px * Test visual regression for changing border-radius-base from 3px to 4px * Test visual regression for changing border-radius-large from 6px to 4px * Test visual regression for changing border-radius-large from 6px to 4px * Revert "Test visual regression for changing border-radius-large from 6px to 4px" This reverts commit 65fd64f. * Test visual regression for changing border-radius-large from 6px to 8px * Revert all changes for regression testing Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com> * Replace shadow() function with tokens (#4823) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Move legacy shadow tokens into a new depth token file * Remove --p-shadow-from-ambient-light legacy token * Remove --p-shadow-from-direct-light legacy token * Remove --p-shadow-from-dim-light legacy token * Update UNRELEASED-v8.md * Add tokens to replace shadow() values * Remove px on 0 values in tokens * Try to give a bit of order to shadow token values * Rename legacy shadow tokens * Replace shadow() with token value * Remove shadow() function and imports * Add missing test entry for new depth tokens * Remove unused $* shadow value * Remove $* shadow value and simplify usage * Convert $* properties to --pc-* * Update README.md * feat: Add stylelint plugin to validate polaris custom properties (#4804) * feat: Extract design tokens to JSON (#4818) * feat: Update CustomProperties component to use JSON tokens (#4822) * feat: Update the custom Stylelint plugin to use JSON tokens (#4828) * node 16.10 (#4831) Co-authored-by: Kyle Durand <kyledurand@Kyles-MacBook-Pro-2.local> * [Maintenance] Clean up css custom properties (#4839) * [Maintenance] Clean up css custom properties * Getting back to visual pairity with main * Remove tokens.ts file * Update src/components/RangeSlider/components/DualThumb/DualThumb.scss * Test(16.10.0) (#4847) * Node 16.9.1 (#4853) * Merge fixes * Update yarn.lock * 👕linting fixes * Update UNRELEASED.md * Line height tokens (#4852) * baseline for chromatic * Add `line-height` tokens * Replace instances of line-height function with tokens * Update FileUpload.scss * Update CustomProperties.test.tsx * Update ActionList.scss * Update CheckableButton.scss * Remove `line-height()` from mixins * Update SkeletonDisplayText.scss * Remove instances of `line-height()` in `Button` * Fix control-height custom property var * Fix button iconOnly margin * Remove `line-height()` declaration * Update line-height token scale * Update src/styles/shared/_buttons.scss * Update src/styles/shared/_controls.scss * Use control-height token and calc Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> * Replace `font-size()` with tokens (#4857) * Update _typography.scss * Create `font-size` tokens * Update `font-size` scale * Replace instances of `font-size()` with tokens * Remove `font-size()` declaration * Fix kitchen sink (#4859) * Remove root level control height (#4860) * Cherry pick "Update root font size" PR #4794 * feat: Remove @shopify/polaris-tokens dependency (#4868) * fix: Add missing yarn.lock updates (#4872) * Replace border-width() with tokens (#4900) * Create border width tokens * Replace instances of `border-width()` with tokens * Remove `border-width()` sass function * feat: move border-width to same file as border-radius * Fix division bugs and Prepare for dart-sass interoperability (#4933) * Improve interoperability between node-sass and dart-sass Using `/` for division is deprecated in dart-sass. Simple cases can be replaced with multiplying by the reciprocal number, which works in both node-sass and dart-sass. e.g. `10 / 2` becomes `10 * 0.5`. This fixes a few warnings that would be raised if you compile with dart-sass. * Remove imports to non-existent files * Fixup cases where / was producing the wrong thing * changelog * Remove ms-high-contrast-color() (#4938) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Replace ms-high-contrast-color('text') with corresponding value * Replace ms-high-contrast-color('disabled-text') with corresponding value * Replace ms-high-contrast-color('selected-text') with corresponding value * Replace ms-high-contrast-color('selected-text-background') with corresponding value * Replace ms-high-contrast-color('button-text') with corresponding value * Remove ms-high-contrast-color() function * Update UNRELEASED-v8.md * Remove file imports for foundation/color * Remove font-family() function (#4940) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Create new tokens for font-families * Replace font-family() with new token * Replace font-family($family: 'monospace') with new token * Streamline font syntax for multi word fonts * Remove font-family() function * Consolidate font-size and line-height token files into typography * Clean up missed imports for fontSize and lineHeight * Remove tests for fontSize and lineHeight * Remove em() function (#4937) * Remove usage of em() everywhere except breakpoints file These values all get passed through breakpoint() which converts pixel values into ems already, so there's no need to wrap these values with em before passing them into breakpoint(). This results in identical css output. * Remove em function. breakpoint() handles em adjustments. Replace usage of em() with breakpoint(). Inline the em tranformation logic into breakpoint(). Remove breakpoint's `$adjustment` variable * Rename `font-family-base` token (#4955) * Update UNRELEASED-v8.md * Rename font-family-base token * Replace `border()` with tokens (#4934) * Add `border` tokens * Replace instances of `border()` with tokens * Remove `border()` scss function * Update UNRELEASED-v9.md * Remove `map-extend` scss function and `_utilities.scss` * Revert "Remove `map-extend` scss function and `_utilities.scss`" This reverts commit 2c51a41. * Update UNRELEASED-v9.md (#4973) Co-Authored-By: aveline <3474483+aveline@users.noreply.github.com> Co-authored-by: aveline <3474483+aveline@users.noreply.github.com> * Remove `available-names` scss function (#4967) * Move `available-names` to layout * Update UNRELEASED-v9.md * Hardcode error string and remove unused function * Remove `unstyled-link()` mixin (#4951) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Replace unstyled-link mixin with values * Remove unstyled-link() mixin * Make &:visited color properties inherit * Remove `unstyled-list()` mixin (#4960) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Replace unstyled-list mixin with values * Remove unstyled-list() mixin * Remove `high-contrast-outline()` and `high-contrast-border()` mixins (#4962) * Update UNRELEASED-v8.md * Update UNRELEASED-v8.md * Replace high-contrast-outline() mixin with tokens and values * Replace high-contrast-border() mixin with tokens and values * Remove high-contrast-outline() and high-contrast-border() mixins * Remove missed import * Remove map extend (#4970) * Remove `map-extend` scss function and `_utilities.scss` * Update UNRELEASED-v9.md * Replace `@mixin state()` with value (#4989) * Update UNRELEASED-v9.md * Update UNRELEASED-v9.md * Replace state(focused) with value * Create --pc- custom property for one off rgba value * Remove state() mixin * feat: Replace `icon-size()` with tokens (#4990) * feat: Collocate SCSS mixins with ResourceList component (#4994) * feat: Remove Skeleton mixins (#4991) * Update UNRELEASED-v9.md * Formatting v9 Changelog (#4996) * Formatting v9 Changelog * Update UNRELEASED-v9.md * Update UNRELEASED-v9.md * feat: Remove print SCSS mixins (#4995) * Remove public scss api (#4993) * Remove public scss api * Update UNRELEASED-v9.md * Remove `/styles` from `/build` * Create migrating-from-v8-to-v9.md * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> * V9.0.0 major rebase (#5012) * [TextStyle] Add warning color variation (#4880) * Add warning color to TextStyle * Add to unreleased Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> * fix: Remove root entry point generation (#4882) * Upgrade nvmrc and dev.yml (#4888) * Fixed checkbox showing on an Autocomplete action when allowMultiple is true (#4887) * Remove serve dependency and dev start command (#4876) Co-authored-by: Alex Page <hi@alexpage.dev> * Bump follow-redirects in /examples/create-react-app-ts-react-testing (#4892) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.12.1 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.12.1...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fixing autocomplete action (#4893) * [Listbox.TextOption] remove pointer event from the Checkbox to avoid losing focus on the Textfield (#4895) * adding pointer events to prevent autocomplete from closing when clicking the checkbox * [TextField] Added a class to hide the clear button instead of removing it from the DOM (#4897) * Polaris release v7.6.0 (#4904) v7.6.0 * Remove _SECRET_INTERNAL_FilterControl export (#4905) * Remove _SECRET_INTERNAL_FilterControl export This component has been deprecated and hidden behind a scary sounding import that does not promise backwards compatability since polaris v5. Legacy usage in web had blocked us from removing it fully, but now web no longer uses this, and thus it can be fully removed. * Remove unused translations * changelog * Polaris v8 (#4907) * Update root font size (#4794) * Update root font size * try a fix for chromatic diffs 🧪 * Update rem values for chromatic snapshots * Update rem values for Chromatic snapshots * Update token values to px * Update rem values to px * Update rems to px * Update px to rem * Update UNRELEASED.md * Bump node to v16 (#4778) * Bump node to v16 * Bump @types/node * bump node-sass, sass-loader * add engines entry to package.json * Remove unused eslint disable, add jsx flag to tsconfig * bump size-limit-action, specify node-version * Remove engines for now, incompatible with size-limit-action * fix lint warnings, add engines * remove jsx flag * wrong action version * node 16.10 (#4831) Co-authored-by: Kyle Durand <kyledurand@Kyles-MacBook-Pro-2.local> * Test(16.10.0) (#4847) * Node 16.9.1 (#4853) * Cherry pick "Update root font size" PR #4794 * Update change log * v8.0.0 Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@Kyles-MacBook-Pro-2.local> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * [Badge] Revert type StatusDeprecated (#4939) * [ButtonGroup] Fix misalignment in segmented items (#4906) * Add display flex to ButtonGroup Item in order to fix mis-alignment when segmented * Update UNRELEASED.md * Update styling and UNRELEASED.md * Update Button.scss styles * Update ButtonGroup Item to use line-height * [Page] fix destructive secondary action not visible (#4647) * fix destructive secondary action not visible * change text color for destructive secondary action * reset Playground.tsx * destructure destructive, add hover state to destructive action & add a destructive example to readme * update UNRELEASED.md * Update 1 translation file (#4947) Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> * Improve error message if sass fails to compile (#4954) Sass errors shall now show a callstack of what triggered the error * Only add min-height to .Row:first-child (#4952) * Only add min-height to .Row:first-child * Update UNRELEASED.md * Add node version update to changelog (#4958) * Add node change to changelog * Update CHANGELOG.md Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> * Update Navigation density (#4874) * chore: tighten nav density on large screens * chore: update readme * chore: update storybook with new minor icons * chore: use spacing over rem * [Navigation] Improve Navigation IA (#4902) * chore: navigation ia improvements * chore: update readme * chore: put duplication behind a prop * chore: update release notes * chore: remove prop due to handling duplicates downstream * chore: updates from merge * [ColorPicker] Add an inset box-shadow to make it easier to see the draggers (#4948) * ColorPicker: add an inset box-shadow to make it easier to see the draggers on a white background * ColorPicker: add an outline for users using High Contrast Mode * [DataTable] Fix table row border bottom (#4975) * [DataTable] Fix table row border bottom The color was darker and inconsistent with the way other table headers are displayed. * Update UNRELEASED.md * Remove icons in FooterHelp (#4982) * [Autocomplete] remove min-height on action (#4977) * remove min-height from Autocomplete Action * [Page] Normalise spacing within Header (#4911) * chore: increase margin of divider in page * chore: address comments from review * Polaris V8 migration guide (#4987) * v8 migration * Update documentation/guides/migrating-from-v7-to-v8.md Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> * [Banner] Fix focus border on secondary action button in banners (#4997) * Replaces focus border on secondary action button in banners * Add release notes to Unreleased.md * Update order of mixins so it matches * fix: update docs (#4999) * [TextField] Add rows to textarea on initial render (#4903) * Fix hard coded px tokens (#5000) * Adjust migration guide and fix --p-border-divider * Fix formatting issues * 💚 * Remove unused $image-size * Update src/components/Page/components/Header/components/Title/Title.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Navigation/_variables.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Navigation/_variables.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Navigation/Navigation.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Navigation/Navigation.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Listbox/components/TextOption/TextOption.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * Update src/components/Listbox/components/Action/Action.scss Co-authored-by: aveline <aveline@users.noreply.github.com> * remove final spacing()s * Use font-weight token Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Roxanne Panthaky <rox163@users.noreply.github.com> Co-authored-by: Aaron Adams <aaron@aaronadams.ca> Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Leroux <dleroux@users.noreply.github.com> Co-authored-by: Sophie Schneider <sophie.schneider@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@Kyles-MacBook-Pro-2.local> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Tyler Noseworthy <69977658+tylernoseworthy@users.noreply.github.com> Co-authored-by: Temitayo <64973828+toyelowo@users.noreply.github.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Marc Thomas <hello@mrcthms.com> Co-authored-by: mathildebuenerd <mathilde.buenerd@shopify.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Amy Fairbrother <amy.fairbrother@shopify.com> Co-authored-by: Matt Zaitley <matt.zaitley@shopify.com> * Rebase part two * Remove unnecessary imports (#5020) * Update shipit.yml to node 16.13.0 * Include migration guidance on css custom properties (#5011) * Include migration guidance on css custom properties * Update migrating-from-v8-to-v9.md Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Create migration guidance for `easing()` function (#5047) * Add migration guidance for easing() * Make language reflective of mixins as well * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: aveline <aveline@users.noreply.github.com> * Add backticks around all values in table Co-authored-by: aveline <aveline@users.noreply.github.com> * Create migration guidance for `duration()` function (#5049) * Add duration() documentation * Remove var from token names * Add in duration token documentation * Create migration guidance for shadow() and tokens (#5051) * Add documentation for ms-high-contrast-color() (#5053) * Create migration guidance for `filter()` function (#5046) * Add filter documentation to new sass functions and mixins section * Include shorthand function names * Remove token replacement section * Add quotes around all parameters * Add more context to replacing functions section * Add in token replacement values with note * Use footnote Markdown * Make language reflective of mixins as well * Get rid of duplicate copy * Add backticks around all values in table * Fix typo Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> * Remove use of var in tokens * Remove color tokens from table Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> * Clean up headings in UNRELEASED * Add documentation for font-family() function (#5081) * Add documentation for unstyled-link() and unstyled-list() mixins (#5093) * Create documentation for border-radius function and tokens (#5080) * docs: Migration guide for the ThemeProvider/CustomProperties component (#5013) * Add spacing to migration guide (#5110) * Add spacing to migration guide * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> * Order by size Co-authored-by: Laura Griffee <laura@mailzone.com> * Add deprecated mega scss public api file (#5113) * Create polaris-v8-public-api.scss * Update documentation/guides/polaris-v8-public-api.scss Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Fix formatting * Prefix file name with legacy * Update legacy-polaris-v8-public-api.scss * Add to stylelintignore Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Create migration guidance for `high-contrast-outline()` and `high-contrast-border()` mixins (#5112) * Add documentation for high-contrast-outline() and high-contrast-border() * Fix typo * Add documentation for border() function (#5115) * Create migration guidance for `border-width()` function (#5114) * Add documentation for border-width() function * Add entry to UNRELEASED-v9 for border-width() * Add migration guidance for rem() (#5117) * Migration guidance `em()` (#5075) * Migration guidance for `em()` * Update migrating-from-v8-to-v9.md * Update em() definition link * Fix `border-divider` token (#5121) * Migration guidance for `px()` (#5074) * Update migrating-from-v8-to-v9.md * Populate link to px() definition * Add migration guidance for px() * Update permalink to highlight range * Create migration guidance for `SkeletonPage` component (#5124) * Adding migration documentation for the skeletonpage component * Running prettier * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> * Create migration guidance for color functions and mixins (#5079) * Add in all color function and mixin headers * Move color() UNRELEASED entry to v9 doc * Add documentation for color functions and mixins * Wording and presentation revisions * Link out section references * Fix typo * Add clarification to documentation * zindex migration guidance (#5119) * zindex migration guidance * Fix z-index tokens * Add devUi value for z-index function * Consolidate megafile sections in the migration guide (#5134) * Create migration guidance for `hidden-when-printing()`, `print-hidden()`, `when-not-printing()`, `when-printing()` functions (#5120) * Add documentation for hidden-when-printing, print-hidden, when-not-printing, when-printing functions * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> * Update documentation/guides/migrating-from-v8-to-v9.md Co-authored-by: Laura Griffee <laura@mailzone.com> Co-authored-by: Laura Griffee <laura@mailzone.com> * Create migration guidance for `icon-size()` function (#5118) * Add documentation for icon-size() function * Running prettier * Consolidate CSS custom properties into one table in the migration guide (#5137) * Consolidate css custom properties into one table * Minor language tweak * Migration guide for skeleton mixins (#5141) * Add documentation for skeleton-page-header-layout() mixin * Add documentation for skeleton-page-secondary-actions-layout() mixin * Create documentation for skeleton-shimmer() mixin * Remove extra semicolon * Collapse `filter()` table (#5142) * Add migration guidance for map-extend() Sass function (#5123) Resolved #5028 * Navigation design update (#5161) Update Navigation spacing and stories to match main * Use divider color token for Index Table filter (#5163) * Turn code blocks into tables (#5162) * Create migration guidance for `available-names()` function (#5122) * Create documentation for available-names() * Link to function definition in mega file * Update table header language * Create migration guidance for `state()` mixin (#5139) * Create documentation for state() mixin * Remove secondary table option * Remove unnecessary style declaration * Add migration guidance for `polaris-tokens` (#5138) * Add migration guidance for `polaris-tokens` * Update polaris-tokens deprecation language * Clarify token and table header language in migration guide (#5164) * Clarify language * Minor noun casing adjustments to migration guide * Minor language tweak Co-authored-by: Sam Rose <sam.rose@shopify.com> * Create migration guidance for Sass global variables (#5160) * Add documentation for sass global variables * Consolidate table * Fix casing * Fix the right casing * Adding migration documentation for the page component (#5173) * Create a table of contents for the migration guide (#5166) * Add existing headers to table of contents * Add new merges * Remove unwanted headers from table of contents * Remove plugin comments * feat: Prefix custom color-scheme attribute (#5182) Co-authored-by: Laura Griffee <laura@mailzone.com> Co-authored-by: Kyle Durand <6844391+kyledurand@users.noreply.github.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> Co-authored-by: Sara Hill <sarashill22@gmail.com> Co-authored-by: Laura Griffee <21976492+lgriffee@users.noreply.github.com> Co-authored-by: Kyle Durand <kyle.durand@shopify.com> Co-authored-by: Aaron Casanova <aaron.casanova@shopify.com> Co-authored-by: Kyle Durand <kyledurand@Kyles-MacBook-Pro-2.local> Co-authored-by: Aveline Thelen <aveline.thelen@shopify.com> Co-authored-by: aveline <3474483+aveline@users.noreply.github.com> Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Roxanne Panthaky <rox163@users.noreply.github.com> Co-authored-by: Aaron Adams <aaron@aaronadams.ca> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Leroux <dleroux@users.noreply.github.com> Co-authored-by: Sophie Schneider <sophie.schneider@shopify.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Tyler Noseworthy <69977658+tylernoseworthy@users.noreply.github.com> Co-authored-by: Temitayo <64973828+toyelowo@users.noreply.github.com> Co-authored-by: translation-platform[bot] <34770790+translation-platform[bot]@users.noreply.github.com> Co-authored-by: Marc Thomas <hello@mrcthms.com> Co-authored-by: mathildebuenerd <mathilde.buenerd@shopify.com> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Amy Fairbrother <amy.fairbrother@shopify.com> Co-authored-by: Matt Zaitley <matt.zaitley@shopify.com> Co-authored-by: Sam Rose <sam.rose@shopify.com> Co-authored-by: Romello Goodman <romellogood@gmail.com> Co-authored-by: Sam Rose <samrose3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4596
To deprecate the duration() function from our public sass API and replace it with tokens. We no longer want to support this functionality in the system.
WHAT is this pull request doing?
duration()--p-duration-200--p-duration-300--p-duration-400--p-duration-500