Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContextualSaveBar] Register secondaryMenu prop in frame context #5116

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

whizkydee
Copy link
Member

WHAT is this pull request doing?

Ref: Shopify/growth-activation#2363

An optional secondaryMenu prop was added to the ContextualSaveBar component in #5018 but wasn't registered in the frame context which prevented content passed to it from being rendered. This PR is simply an hotfix for that.

How to 馃帺

馃枼 Local development instructions
馃棐 General tophatting guidelines
馃搫 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';

import {Page, Button, ContextualSaveBar, Frame} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      <Frame>
        <ContextualSaveBar
          secondaryMenu={<Button>Setup Guide</Button>}
          discardAction={{content: 'Discard'}}
          saveAction={{content: 'Save'}}
        />
      </Frame>
    </Page>
  );
}

Confirm that a button that says "Setup Guide" is rendered before the discard and save buttons

馃帺 checklist

@whizkydee whizkydee self-assigned this Feb 9, 2022
@whizkydee whizkydee force-pushed the hotfix/contextual-save-bar-secondary-menu-prop branch from 243c088 to a3e7e25 Compare February 9, 2022 21:02
@whizkydee whizkydee marked this pull request as ready for review February 9, 2022 21:02
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

size-limit report

Path Size
cjs 164.57 KB (+0.01% 馃敽)
esm 94.31 KB (+0.01% 馃敽)
esnext 141.41 KB (+0.02% 馃敽)
css 34.65 KB (0%)

@whizkydee whizkydee merged commit b07102c into main Feb 10, 2022
@whizkydee whizkydee deleted the hotfix/contextual-save-bar-secondary-menu-prop branch February 10, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants