Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

[Design Language] Shadow token #78

Closed
4 tasks
alex-page opened this issue Sep 19, 2019 · 1 comment
Closed
4 tasks

[Design Language] Shadow token #78

alex-page opened this issue Sep 19, 2019 · 1 comment
Labels
🌈 Polaris for everyone Polaris for everyone team
Milestone

Comments

@alex-page
Copy link
Member

alex-page commented Sep 19, 2019

Screen Shot 2019-09-19 at 9 58 25 AM

Screen Shot 2019-09-19 at 2 01 10 PM

https://www.figma.com/file/UNskjfsGU4YoDWqJ0BJBN32i/Product-Design-Language---Master?node-id=3141%3A2

Known values

  • 0 0 1px
  • 1px 0 2px
  • 6px 0 1px
  • 8px 0 2px

Suggested tokens

{
  depth: [
    '0 0 1px',
    '1px 0 2px',
    '6px 0 1px',
    '8px 0 2px',
    '50px 0 2px',
    '0px 1px 2px inset',
  },
}

Discussion points

Should this be called Shadow? This is what the token values create. Depth is the outcome that the shadow creates. Shadow is also what is used in CSS.

@alex-page alex-page added this to the v6.0.0 milestone Sep 19, 2019
@alex-page alex-page changed the title [Masterbrand] Shadow token [Masterbrand] Depth token Sep 20, 2019
@alex-page alex-page changed the title [Masterbrand] Depth token [Masterbrand] Shadow token Sep 20, 2019
@alex-page
Copy link
Member Author

I had a chat with @jessebc about naming this Depth vs Shadow. The thought was that Depth is created from multiple tokens, surface colors, blur, opacity and shadow. On a primitive level the token this would be describing is the shadow values.

@alex-page alex-page added the 🌈 Polaris for everyone Polaris for everyone team label Sep 23, 2019
@alex-page alex-page changed the title [Masterbrand] Shadow token [Design Language] Shadow token Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌈 Polaris for everyone Polaris for everyone team
Projects
None yet
Development

No branches or pull requests

1 participant