Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkeletonPage shows the title inline with the backAction while the Page component doesn't #12223

Open
BaggioGiacomo opened this issue Jun 6, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@BaggioGiacomo
Copy link

BaggioGiacomo commented Jun 6, 2024

Summary

Hi there!

On mobile devices, the SkeletonPage shows the title inline with the back button while the Page component shows the title under the back button (leaving a big blank space between the back button and the other actions)

In addition to causing CLS, are we sure that showing the title under the back button is ok to see?

Expected behavior

I expect to have the same behaviour from the SkeletonPage component and the Page component
Personal preference: I expect the title to be inline with the back button on the Page component

Actual behavior

This is the skeleton page I show the merchant while fetching the data used by the page:
image

I expect the title to be on the green square, am I wrong?

This is the page the merchant sees after the loading page:
image

Steps to reproduce

Create a really basic component that has a <Page> and SkeletonPage with title and backAction set or have a look at this CodeSandbox

<>
  <Page title="title" backAction={{ onAction: () => null }}>
    <Card>Awesome content</Card>
  </Page>
  <SkeletonPage title="title" backAction>
    <Card>Awesome skeleton content</Card>
  </SkeletonPage>
</>

Are you using React components?

Yes

Polaris version number

13.5.0

Browser

Brave

Device

MacBook Air M1 2020

@BaggioGiacomo BaggioGiacomo added Bug Something is broken and not working as intended in the system. untriaged labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant