Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkbox] Disabled does not disable control #1363

Closed
aishad opened this issue Apr 25, 2019 · 1 comment · Fixed by #1369
Closed

[Checkbox] Disabled does not disable control #1363

aishad opened this issue Apr 25, 2019 · 1 comment · Fixed by #1369
Assignees
Labels
Bug Something is broken and not working as intended in the system.

Comments

@aishad
Copy link
Contributor

aishad commented Apr 25, 2019

Issue summary

When setting the checkbox to disabled, it’s rendered as disabled (greyed/subdued colour) yet it can still be toggled.

Expected behavior

When set to disabled, controls should not be interacted with / should not be able to toggle.

Steps to reproduce the problem

https://polaris.shopify.com/components/forms/checkbox

giphy

cc: @AndrewMusgrave

@ghost
Copy link

ghost commented Apr 25, 2019

👋 Thanks for opening your first issue. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants